Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/hashicorp/terraform-plugin-framework from 1.7.0 to 1.8.0 in the terraform-devex group #36992

Merged
merged 9 commits into from
Apr 25, 2024
Merged

build(deps): bump github.com/hashicorp/terraform-plugin-framework from 1.7.0 to 1.8.0 in the terraform-devex group #36992

merged 9 commits into from
Apr 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 19, 2024 •
edited
Loading

Bumps the terraform-devex group with 1 update: github.com/hashicorp/terraform-plugin-framework.

Updates github.com/hashicorp/terraform-plugin-framework from 1.7.0 to 1.8.0

Release notes

Sourced from github.com/hashicorp/terraform-plugin-framework's releases.

v1.8.0

BREAKING CHANGES:

  • function: Removed Definition type Parameter() method (#968)

NOTES:

  • function: Provider-defined function features are now considered generally available and protected by compatibility promises (#966)
  • attr/xattr: The TypeWithValidate interface has been deprecated in preference of the ValidateableAttribute interface. A ValidatableParameter interface has also been added to the function package (#968)

FEATURES:

  • attr/xattr: Added ValidateableAttribute interface for custom value type implementations (#968)
  • function: Added ValidateableParameter interface for custom value type implementations (#968)
  • function: Add BoolParameterValidator, DynamicParameterValidator, Float64ParameterValidator, Int64ParameterValidator, ListParameterValidator, MapParameterValidator, NumberParameterValidator, ObjectParameterValidator, SetParameterValidator, and StringParameterValidator interfaces for custom function parameter validation implementations. (#971)
  • function: Add ParameterWithBoolValidators, ParameterWithInt64Validators, ParameterWithFloat64Validators, ParameterWithDynamicValidators, ParameterWithListValidators, ParameterWithMapValidators, ParameterWithNumberValidators, ParameterWithObjectValidators, ParameterWithSetValidators, and ParameterWithStringValidators interfaces to enable parameter-based validation support (#971)

BUG FIXES:

  • types/basetypes: Prevented panic in the MapValue types Equal method when the receiver has a nil elementType (#961)
  • types/basetypes: Prevented panic in the ListValue types Equal method when the receiver has a nil elementType (#961)
  • types/basetypes: Prevented panic in the SetValue types Equal method when the receiver has a nil elementType (#961)
  • resource: Ensured computed-only dynamic attributes will not cause wrong final value type errors during planning (#969)
Changelog

Sourced from github.com/hashicorp/terraform-plugin-framework's changelog.

1.8.0 (April 18, 2024)

BREAKING CHANGES:

  • function: Removed Definition type Parameter() method (#968)

NOTES:

  • function: Provider-defined function features are now considered generally available and protected by compatibility promises (#966)
  • attr/xattr: The TypeWithValidate interface has been deprecated in preference of the ValidateableAttribute interface. A ValidatableParameter interface has also been added to the function package (#968)

FEATURES:

  • attr/xattr: Added ValidateableAttribute interface for custom value type implementations (#968)
  • function: Added ValidateableParameter interface for custom value type implementations (#968)
  • function: Add BoolParameterValidator, DynamicParameterValidator, Float64ParameterValidator, Int64ParameterValidator, ListParameterValidator, MapParameterValidator, NumberParameterValidator, ObjectParameterValidator, SetParameterValidator, and StringParameterValidator interfaces for custom function parameter validation implementations. (#971)
  • function: Add ParameterWithBoolValidators, ParameterWithInt64Validators, ParameterWithFloat64Validators, ParameterWithDynamicValidators, ParameterWithListValidators, ParameterWithMapValidators, ParameterWithNumberValidators, ParameterWithObjectValidators, ParameterWithSetValidators, and ParameterWithStringValidators interfaces to enable parameter-based validation support (#971)

BUG FIXES:

  • types/basetypes: Prevented panic in the MapValue types Equal method when the receiver has a nil elementType (#961)
  • types/basetypes: Prevented panic in the ListValue types Equal method when the receiver has a nil elementType (#961)
  • types/basetypes: Prevented panic in the SetValue types Equal method when the receiver has a nil elementType (#961)
  • resource: Ensured computed-only dynamic attributes will not cause wrong final value type errors during planning (#969)
Commits
  • 711b0a5 Update changelog
  • 9d9533c build(deps): Bump github.com/hashicorp/terraform-plugin-go (#984)
  • 23c2403 Remove wildcard suffix from setup_terraform workflow call (#981)
  • 392ed7c website: Update testing documentation to utilize new statecheck and `knownv...
  • de32b2c basetypes: fix equality for values with nil elementType (#961)
  • d36ac87 Add parameter-based provider-defined function validation (#971)
  • f6057df docs: Remove technical preview verbiage from provider-defined functions (#972)
  • 4a9b6a3 Add type-based provider-defined function parameter validation (#968)
  • 541a7cb Small edit for style on a code comment (#975)
  • 484f311 internal/fwserver: Ensure computed dynamic values are marked as dynamic type ...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Used to indicate dependency changes. go Pull requests that update Go code labels Apr 19, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/S Managed by automation to categorize the size of a PR. label Apr 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
@jar-b jar-b self-assigned this Apr 19, 2024
@jar-b jar-b force-pushed the dependabot/go_modules/terraform-devex-94a6ffc918 branch from 896a2af to 57db94f Compare April 19, 2024 20:37
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 22, 2024
@jar-b jar-b marked this pull request as draft April 22, 2024 15:05
@jar-b jar-b force-pushed the dependabot/go_modules/terraform-devex-94a6ffc918 branch 3 times, most recently from b8f20b8 to b1f6063 Compare April 22, 2024 19:18
@jar-b jar-b marked this pull request as ready for review April 22, 2024 19:24
@github-actions github-actions bot added service/redshift Issues and PRs that pertain to the redshift service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/shield Issues and PRs that pertain to the shield service. service/kinesis Issues and PRs that pertain to the kinesis service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. service/apprunner Issues and PRs that pertain to the apprunner service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 23, 2024
@jar-b jar-b requested a review from a team April 24, 2024 14:41
jar-b
jar-b reviewed Apr 24, 2024
View reviewed changes
internal/framework/types/arn.go
Comment on lines -146 to -147
func ARNValueMust(value string) ARN {
return fwdiag.Must(ARNValue(value))
Copy link
Member

@jar-b jar-b Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that validation is done on the value (during validate, plan, or apply), I opted to remove the Must variant of any constructors which had one.

There were only a few instances where the ARNValue constructor was being used at runtime with handling for the returned diagnostics. I replaced those with direct calls to arn.Parse to guarantee the validity of the ARN value prior to initializing the value. Everywhere ARNValueMust was used has been replaced with the updated ARNValue signature that does not return diagnostics.

dependabot bot and others added 2 commits April 24, 2024 10:53
@dependabot @jar-b
build(deps): bump github.com/hashicorp/terraform-plugin-framework
050523e 
Bumps the terraform-devex group with 1 update: [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework).


Updates `github.com/hashicorp/terraform-plugin-framework` from 1.7.0 to 1.8.0
- [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-framework@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-devex
...

Signed-off-by: dependabot[bot] <support@github.com>
@jar-b
internal/framework/types: covert string enum to value validation
71455b4
@jar-b
internal/framework/types: convert arn to value validation
d0595d9
@jar-b
internal/framework/types: remove ARNValueMust function
9516ce9 
Initialization of a known `ARN` type now can only be done via the `ARNValue` function. The `ARNValueMust` function has been removed, and validation previously applied during initialization has moved into the `ValidateAttribute` method.

This change has minimal impact to most existing usages of the initialization functions. In the cases where the diagnostics response from `ARNValue` was being explicitly handled, the `arn.Parse` function has been inserted instead, providing the same effect the init-time validation previously supplied.
@jar-b
internal/framework/types: convert cidr block to value validation
15c8fd7
@jar-b
internal/framework/types: convert duration to value validation
b9f0afe
@jar-b
internal/framework/types: convert iam policy to value validation
ab51eba
@jar-b
internal/framework/types: convert once a week window to value validation
e1be78d
@jar-b
internal/framework/types: convert regexp to value validation
fa504f7
@jar-b jar-b force-pushed the dependabot/go_modules/terraform-devex-94a6ffc918 branch from b1f6063 to fa504f7 Compare April 24, 2024 14:53
ewbankkit
ewbankkit approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit eda7c63 into main Apr 25, 2024
61 checks passed
@jar-b jar-b deleted the dependabot/go_modules/terraform-devex-94a6ffc918 branch April 25, 2024 18:09
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 25, 2024
@jar-b jar-b mentioned this pull request Apr 25, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
Update CHANGELOG.md for #36992
2e71459
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Apr 26, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@jar-b jar-b

Labels
dependencies Used to indicate dependency changes. go Pull requests that update Go code service/apprunner Issues and PRs that pertain to the apprunner service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/kinesis Issues and PRs that pertain to the kinesis service. service/redshift Issues and PRs that pertain to the redshift service. service/shield Issues and PRs that pertain to the shield service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @jar-b